Add Debug Adapter Protocol (DAP) support #5
Conversation
| const disposer = client.onNotification( | ||
| "marimo/dap", | ||
| ({ sessionId, message }) => { | ||
| Logger.debug("Debug.Receive", "Received DAP response from LSP", { | ||
| sessionId, | ||
| message, | ||
| }); | ||
| if (sessionId === session.id) { | ||
| sendMessage.fire(message); | ||
| } | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Responses from the request handler.
| executeCommand(client, { | ||
| command: "marimo.dap", | ||
| params: { | ||
| sessionId: session.id, | ||
| notebookUri: session.configuration.notebookUri, | ||
| message, | ||
| }, |
There was a problem hiding this comment.
Custom LSP "command" that wraps a DAP request with additional information (for a request). I assume that the handler will manage its own debug sessions.
| """Command-specific arguments. Should be parsed further in ./debug_adapter.py""" | ||
|
|
||
|
|
||
| def handle_debug_adapter_request( |
There was a problem hiding this comment.
barebones request/response. I assume this is where your large conditional thing would go @dmadisetti
manzt
changed the title
manzt
force-pushed
the
push-klosomrynunw
branch
from
452fbcc to
cb0d170
Compare
manzt
force-pushed
the
main
branch
2 times, most recently
from
5e534ff to
f1de986
Compare
manzt
force-pushed
the
push-klosomrynunw
branch
from
cb0d170 to
a177e13
Compare
|
I'm going to make a PR to this PR- but we can sync Monday for upstream merge |
|
I just merged some linting/formatting changes in #6 for the extension code. Would I be able to rebase this branch cleanly for you? |
|
I might get up my pwn branch and close this out. Will manage rebase issues, but ping you if something seems to hairy. Thanks again! |
|
Can we just squash this into main then? Or are your changes a significant departure from this? It would be nice to break up the DAP stuff into separate PRs I think so it's easier to review. |
dmadisetti
left a comment
dmadisetti
left a comment
There was a problem hiding this comment.
I'd be happy getting this into main if you are!
Enables debugging marimo notebooks in VS Code by forwarding DAP messages between the VS Code debugger and the LSP server. Just a stub now to wire up everything.
manzt
force-pushed
the
push-klosomrynunw
branch
from
1a6a560 to
6484853
Compare
|
Cool, I merged |
Adds initial boilerplate to connect DAP with marimo-lsp. The VS Code extension now forwards DAP messages over LSP, which has access to the session state as well as the document workspace.
Screen.Recording.2025-08-20.at.5.32.05.PM.mov